linux-kernel - Re: [PATCH RFC v7 24/64] crypto:ccp: Define the SEV-SNP commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <377e3bba-3948-908d-610d-d9961518498b@amazon.com>
Date:   Sun, 22 Jan 2023 18:09:33 +0200
From:   Sabin Rapan <sabrapan@...zon.com>
To:     Michael Roth <michael.roth@....com>, <kvm@...r.kernel.org>
CC:     <linux-coco@...ts.linux.dev>, <linux-mm@...ck.org>,
        <linux-crypto@...r.kernel.org>, <x86@...nel.org>,
        <linux-kernel@...r.kernel.org>, <tglx@...utronix.de>,
        <mingo@...hat.com>, <jroedel@...e.de>, <thomas.lendacky@....com>,
        <hpa@...or.com>, <ardb@...nel.org>, <pbonzini@...hat.com>,
        <seanjc@...gle.com>, <vkuznets@...hat.com>,
        <wanpengli@...cent.com>, <jmattson@...gle.com>, <luto@...nel.org>,
        <dave.hansen@...ux.intel.com>, <slp@...hat.com>,
        <pgonda@...gle.com>, <peterz@...radead.org>,
        <srinivas.pandruvada@...ux.intel.com>, <rientjes@...gle.com>,
        <dovmurik@...ux.ibm.com>, <tobin@....com>, <bp@...en8.de>,
        <vbabka@...e.cz>, <kirill@...temov.name>, <ak@...ux.intel.com>,
        <tony.luck@...el.com>, <marcorr@...gle.com>,
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        <alpergun@...gle.com>, <dgilbert@...hat.com>, <jarkko@...nel.org>,
        <ashish.kalra@....com>, <harald@...fian.com>,
        Brijesh Singh <brijesh.singh@....com>
Subject: Re: [PATCH RFC v7 24/64] crypto:ccp: Define the SEV-SNP commands



On 14.12.2022 21:40, Michael Roth wrote:
> From: Brijesh Singh <brijesh.singh@....com>
> 
> +/*
> + * struct sev_user_data_snp_config - system wide configuration value for SNP.
> + *
> + * @reported_tcb: The TCB version to report in the guest attestation report.
> + * @mask_chip_id: Indicates that the CHID_ID field in the attestation report
> + * will always be zero.
> + */
> +struct sev_user_data_snp_config {
> +       __u64 reported_tcb;     /* In */
> +       __u32 mask_chip_id;     /* In */
> +       __u8 rsvd[52];
> +} __packed;
> +

Based on table 45 section 8.6.1 in
https://www.amd.com/system/files/TechDocs/56860.pdf I think this should be 

struct sev_user_data_snp_config {
       __u64 reported_tcb;     /* In */
       __u32 mask_chip_id:1;     /* In */
       __u32 mask_chip_key:1;     /* In */
       __u32 rsvd:30;
       __u8 rsvd1[52];
} __packed;


--
Sabin.



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.