linux-kernel - Re: [PATCH] m68k:do not initialise statics to 0.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 22 Jan 2023 17:33:19 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     gaoxin@...rlc.com
Cc:     linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k:do not initialise statics to 0.

Hi Xin,

On Mon, Jul 18, 2022 at 12:56 PM Xin Gao <gaoxin@...rlc.com> wrote:
> Delete static variables initialized to 0.
>
> Signed-off-by: Xin Gao <gaoxin@...rlc.com>

Thanks for your patch!

> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -201,8 +201,8 @@ static int ccleirq=60;    /* ISA dev IRQs*/
>  #define DEBUG_Q40INT
>  /*#define IP_USE_DISABLE *//* would be nice, but crashes ???? */
>
> -static int mext_disabled=0;  /* ext irq disabled by master chip? */
> -static int aliased_irq=0;  /* how many times inside handler ?*/
> +static int mext_disabled;  /* ext irq disabled by master chip? */
> +static int aliased_irq;  /* how many times inside handler ?*/
>
>
>  /* got interrupt, dispatch to ISA or keyboard/timer IRQs */

Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
i.e. will queue in the m68k for-v6.3 branch.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds