linux-kernel - [PATCH] paride: Mark PARIDE as deprecated, point to PATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230122181415.21031-1-linux@zary.sk>
Date:   Sun, 22 Jan 2023 19:14:15 +0100
From:   Ondrej Zary <linux@...y.sk>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>
Cc:     Christoph Hellwig <hch@....de>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        Jens Axboe <axboe@...nel.dk>, Tim Waugh <tim@...erelk.net>,
        linux-block@...r.kernel.org, linux-parport@...ts.infradead.org,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] paride: Mark PARIDE as deprecated, point to PATA_PARPORT

Add Kconfig and runtime deprecation warnings to PARIDE, pointing users
to PATA_PARPORT.

Signed-off-by: Ondrej Zary <linux@...y.sk>
---
 drivers/block/Kconfig         | 4 +++-
 drivers/block/paride/paride.c | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index a2184b428493..3a2065c6a4d7 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -104,7 +104,7 @@ config GDROM
 	  You can also build this as a module which will be called gdrom.
 
 config PARIDE
-	tristate "Parallel port IDE device support"
+	tristate "Parallel port IDE device support (DEPRECATED)"
 	depends on PARPORT_PC
 	help
 	  There are many external CD-ROM and disk devices that connect through
@@ -130,6 +130,8 @@ config PARIDE
 	  "MicroSolutions backpack protocol", "DataStor Commuter protocol"
 	  etc.).
 
+	  This driver is deprecated, replaced by libata-based PATA_PARPORT.
+
 source "drivers/block/paride/Kconfig"
 
 source "drivers/block/mtip32xx/Kconfig"
diff --git a/drivers/block/paride/paride.c b/drivers/block/paride/paride.c
index 0e287993b778..010daf605728 100644
--- a/drivers/block/paride/paride.c
+++ b/drivers/block/paride/paride.c
@@ -452,6 +452,8 @@ void *pi_register_driver(char *name)
 	struct parport_driver *parp_drv;
 	int ret;
 
+	printk(KERN_WARNING "PARIDE is deprecated. Use PATA_PARPORT instead.\n");
+
 	parp_drv = kzalloc(sizeof(*parp_drv), GFP_KERNEL);
 	if (!parp_drv)
 		return NULL;
-- 
Ondrej Zary