linux-kernel - Re: [PATCH] nfsd: don't free files unconditionally in __nfsd_file_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 22 Jan 2023 23:40:25 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Shachar Kagan <skagan@...dia.com>
CC:     Jeff Layton <jlayton@...nel.org>,
        Ruben Vestergaard <rubenv@...mr.dk>,
        Torkil Svensgaard <torkil@...mr.dk>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nfsd: don't free files unconditionally in
 __nfsd_file_cache_purge



> On Jan 22, 2023, at 9:58 AM, Shachar Kagan <skagan@...dia.com> wrote:
> 
> 
> On Sun, 2023-01-22 at 16:58 +0000, Shachar Kagan wrote:
> 
>> On Sat, 2023-01-21 at 17:04 +0000, Chuck Lever III wrote:
>>> 
>>>> On Jan 20, 2023, at 3:54 PM, Jeff Layton <jlayton@...nel.org> wrote:
>>>> 
>>>> On Fri, 2023-01-20 at 20:21 +0000, Chuck Lever III wrote:
>>>>> 
>>>>>> On Jan 20, 2023, at 2:52 PM, Jeff Layton <jlayton@...nel.org> wrote:
>>>>>> 
>>>>>> nfsd_file_cache_purge is called when the server is shutting 
>>>>>> down, in which case, tearing things down is generally fine, but 
>>>>>> it also gets called when the exports cache is flushed.
>>>>> 
>>>>> Yeah... cache flush is probably the case we've been missing.
>>>>> 
>>>>> 
>>>>>> Instead of walking the cache and freeing everything 
>>>>>> unconditionally, handle it the same as when we have a notification of conflicting access.
>>>>>> 
>>>>>> Fixes: ac3a2585f018 ("nfsd: rework refcounting in filecache")
>>>>>> Reported-by: Ruben Vestergaard <rubenv@...mr.dk>
>>>>>> Reported-by: Torkil Svensgaard <torkil@...mr.dk>
>>>>>> Reported-by: Shachar Kagan <skagan@...dia.com>
>>>>>> Signed-off-by: Jeff Layton <jlayton@...nel.org>
> 
> I ran our tests with the commit, the issue didn't occur.
> Thanks for the quick response.

May I add Tested-by: Shachar Kagan <skagan@...dia.com> ?

--
Chuck Lever