linux-kernel - RE: [RFC PATCH v6 1/6] KVM: x86: only allow exits disable before vCPUs created

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR12MB35000D46146BA68EE294953BCACB9@DM6PR12MB3500.namprd12.prod.outlook.com>
Date:   Sun, 22 Jan 2023 01:48:35 +0000
From:   Kechen Lu <kechenl@...dia.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "seanjc@...gle.com" <seanjc@...gle.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "zhi.wang.linux@...il.com" <zhi.wang.linux@...il.com>,
        "chao.gao@...el.com" <chao.gao@...el.com>,
        "shaoqin.huang@...el.com" <shaoqin.huang@...el.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [RFC PATCH v6 1/6] KVM: x86: only allow exits disable before
 vCPUs created

Hi Greg,

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Friday, January 20, 2023 11:28 PM
> To: Kechen Lu <kechenl@...dia.com>
> Cc: kvm@...r.kernel.org; seanjc@...gle.com; pbonzini@...hat.com;
> zhi.wang.linux@...il.com; chao.gao@...el.com; shaoqin.huang@...el.com;
> vkuznets@...hat.com; linux-kernel@...r.kernel.org;
> stable@...r.kernel.org
> Subject: Re: [RFC PATCH v6 1/6] KVM: x86: only allow exits disable before
> vCPUs created
> 
> External email: Use caution opening links or attachments
> 
> 
> On Sat, Jan 21, 2023 at 02:07:33AM +0000, Kechen Lu wrote:
> > From: Sean Christopherson <seanjc@...gle.com>
> >
> > Since VMX and SVM both would never update the control bits if exits
> > are disable after vCPUs are created, only allow setting exits disable
> > flag before vCPU creation.
> >
> > Fixes: 4d5422cea3b6 ("KVM: X86: Provide a capability to disable MWAIT
> > intercepts")
> >
> > Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> 
> Nit, no blank line between fixes and signed-off-by please.

Ack.

> 
> And an RFC on v6?  An RFC usually means "I don't think this is correct so do
> not take it".  How can you do that for 6 versions?  And know that no one will
> take an RFC series for that reason (or at least I will
> not...)

Thanks for correcting this, this is my bad. The v2 to v4 revisions, there are big changes 
on the following patches after this prerequisite patch, so I still "RFC" for the design.
But I should drop the "RFC" starting from v5, there are already consensus on the v5 design 
options

Best Regards,
Kechen

> 
> thanks,
> 
> greg k-h