lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 23 Jan 2023 17:05:40 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>, - <devicetree@...r.kernel.org>,
        linux-riscv@...ts.infradead.org,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Tomer Maimon <tmaimon77@...il.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Peter Korsgaard <jacmet@...site.dk>,
        Chester Lin <clin@...e.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-stm32@...md-mailman.stormreply.com,
        Kevin Hilman <khilman@...libre.com>,
        linux-kernel@...r.kernel.org, Fugang Duan <fugang.duan@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Fabio Estevam <festevam@...il.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Le Ray <erwan.leray@...s.st.com>,
        Michal Simek <michal.simek@...inx.com>,
        Lubomir Rintel <lkundrak@...sk>,
        Jerome Brunet <jbrunet@...libre.com>,
        Magnus Damm <magnus.damm@...il.com>,
        Pragnesh Patel <pragnesh.patel@...ive.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-amlogic@...ts.infradead.org,
        NXP Linux Team <linux-imx@....com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 11/13] dt-bindings: serial: restrict possible child node names


On Mon, 23 Jan 2023 16:13:00 +0100, Krzysztof Kozlowski wrote:
> The re-usable serial.yaml schema matches every property with ".*"
> pattern, thus any other schema referencing it will not report unknown
> (unevaluated) properties.  This hides several wrong properties.  It is
> a limitation of dtschema, thus provide a simple workaround: expect
> children to be only of few names matching upstream usage (Bluetooth,
> GNSS, GPS and MCU).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bus/intel,ixp4xx-expansion-bus-controller.example.dtb: serial@1,0: Unevaluated properties are not allowed ('intel,ixp4xx-eb-byte-access', 'intel,ixp4xx-eb-cycle-type', 'intel,ixp4xx-eb-t3', 'intel,ixp4xx-eb-write-enable' were unexpected)
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/8250.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230123151302.368277-11-krzysztof.kozlowski@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ