[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y85YncUCtRyVnpvt@kroah.com>
Date: Mon, 23 Jan 2023 10:51:25 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Li Chen <lchen@...arella.com>
Cc: Jiri Slaby <jirislaby@...nel.org>, Li Chen <me@...ux.beauty>,
Sumit Semwal <sumit.semwal@...aro.org>,
Christian König <christian.koenig@....com>,
open list <linux-kernel@...r.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
"moderated list:ARM/Ambarella SoC support"
<linux-arm-kernel@...ts.infradead.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@...r.kernel.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<dri-devel@...ts.freedesktop.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@...ts.linaro.org>
Subject: Re: [PATCH 10/15] serial: ambarella: add support for Ambarella
uart_port
On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote:
> This driver add support for Ambarella's uart, which
> can be used for console and etc.
>
> Signed-off-by: Li Chen <lchen@...arella.com>
> Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730
> ---
> MAINTAINERS | 1 +
> drivers/tty/serial/Kconfig | 16 +
> drivers/tty/serial/Makefile | 1 +
> drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++
> drivers/tty/serial/ambarella_uart.h | 120 ++
Why do you need a .h file for a single .c file? They should all be in
one file please.
Also, no change-id, you know this...
thanks,
greg k-h
Powered by blists - more mailing lists