linux-kernel - Re: [PATCH v2] drivers/base/memory: Use array to show memory block state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3842ed6a-6c9d-7909-2ab8-106cb4897973@redhat.com>
Date:   Mon, 23 Jan 2023 11:33:28 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Gavin Shan <gshan@...hat.com>, linux-mm@...ck.org
Cc:     linux-kernel@...r.kernel.org, osalvador@...e.de,
        gregkh@...uxfoundation.org, rafael@...nel.org, shan.gavin@...il.com
Subject: Re: [PATCH v2] drivers/base/memory: Use array to show memory block
 state

On 21.01.23 00:38, Gavin Shan wrote:
> Use an array to show memory block state from '/sys/devices/system/
> memory/memoryX/state', to simplify the code. Besides, WARN_ON()
> is removed since the warning can be caught by the return value,
> which is "ERROR-UNKNOWN-%ld\n". A system reboot caused by WARN_ON()
> is definitely unexpected as Greg mentioned.
> 
> No functional change intended.
> 
> Signed-off-by: Gavin Shan <gshan@...hat.com>
> ---

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb