linux-kernel - Re: [PATCH] platform/x86: dell-wmi: Add a keymap for KEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4a85a55-429f-eb5e-3063-e5e79d4baef6@redhat.com>
Date:   Mon, 23 Jan 2023 14:29:40 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Koba Ko <koba.ko@...onical.com>, Mark Gross <markgross@...nel.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: dell-wmi: Add a keymap for KEY_MUTE in type
 0x0010 table

Hi,

On 1/17/23 13:34, Koba Ko wrote:
> Some platforms send the speaker-mute key from EC. dell-wmi can't
> recognize it.
> 
> Add a new keymap for KEY_MUTE in type 0x0010 table.
> 
> Signed-off-by: Koba Ko <koba.ko@...onical.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> index 0a259a27459f6..502783a7adb11 100644
> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> @@ -261,6 +261,9 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
>  	{ KE_KEY,    0x57, { KEY_BRIGHTNESSDOWN } },
>  	{ KE_KEY,    0x58, { KEY_BRIGHTNESSUP } },
>  
> +	/*Speaker Mute*/
> +	{ KE_KEY, 0x109, { KEY_MUTE} },
> +
>  	/* Mic mute */
>  	{ KE_KEY, 0x150, { KEY_MICMUTE } },
>