linux-kernel - Re: [PATCH] platform/x86: hp-wmi: Handle Omen Key event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d75815a-d3a4-0b82-5f4a-02caa01ba35a@redhat.com>
Date:   Mon, 23 Jan 2023 14:34:50 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Rishit Bansal <rishitbansal0@...il.com>,
        Mark Gross <markgross@...nel.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: hp-wmi: Handle Omen Key event

Hi,

On 1/23/23 14:32, Hans de Goede wrote:
> Hi,
> 
> On 1/17/23 23:38, Rishit Bansal wrote:
>> Add support to map the "HP Omen Key" to KEY_PROG2. Laptops in the HP
>> Omen Series open the HP Omen Command Center application on windows. But,
>> on linux it fails with the following message from the hp-wmi driver:
>>
>> [ 5143.415714] hp_wmi: Unknown event_id - 29 - 0x21a5
>>
>> Signed-off-by: Rishit Bansal <rishitbansal0@...il.com>
> 
> Thank you for your patch, I've applied this patch to my review-hans 
> branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
> 
> Note it will show up in my review-hans branch once I've pushed my
> local branch there, which might take a while.
> 
> Once I've run some tests on this branch the patches there will be
> added to the platform-drivers-x86/for-next branch and eventually
> will be included in the pdx86 pull-request to Linus for the next
> merge-window.

I just noticed you send out a v2. I'll replace the patch in my
branch with v2 instead.

Regards,

Hans


>> ---
>>  drivers/platform/x86/hp/hp-wmi.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
>> index 0a99058be813..d8ba3c483901 100644
>> --- a/drivers/platform/x86/hp/hp-wmi.c
>> +++ b/drivers/platform/x86/hp/hp-wmi.c
>> @@ -91,6 +91,7 @@ enum hp_wmi_event_ids {
>>  	HPWMI_BATTERY_CHARGE_PERIOD	= 0x10,
>>  	HPWMI_SANITIZATION_MODE		= 0x17,
>>  	HPWMI_SMART_EXPERIENCE_APP	= 0x21,
>> +	HPWMI_OMEN_KEY				= 0x1D,
>>  };
>>  
>>  /*
>> @@ -219,6 +220,7 @@ static const struct key_entry hp_wmi_keymap[] = {
>>  	{ KE_KEY, 0x21a9,  { KEY_TOUCHPAD_OFF } },
>>  	{ KE_KEY, 0x121a9, { KEY_TOUCHPAD_ON } },
>>  	{ KE_KEY, 0x231b,  { KEY_HELP } },
>> +	{ KE_KEY, 0x21a5,  { KEY_PROG2 }}, /* HP Omen Key */
>>  	{ KE_END, 0 }
>>  };
>>  
>> @@ -810,6 +812,7 @@ static void hp_wmi_notify(u32 value, void *context)
>>  	case HPWMI_SMART_ADAPTER:
>>  		break;
>>  	case HPWMI_BEZEL_BUTTON:
>> +	case HPWMI_OMEN_KEY:
>>  		key_code = hp_wmi_read_int(HPWMI_HOTKEY_QUERY);
>>  		if (key_code < 0)
>>  			break;