linux-kernel - Re: [PATCH v3 1/5] i2c: hpe: Add GXP SoC I2C Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2023 05:11:45 +0000
From:   Joel Stanley <joel@....id.au>
To:     nick.hawkins@....com
Cc:     verdun@....com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux@...linux.org.uk,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 1/5] i2c: hpe: Add GXP SoC I2C Controller

On Fri, 20 Jan 2023 at 19:04, <nick.hawkins@....com> wrote:
>
> From: Nick Hawkins <nick.hawkins@....com>

> +static int gxp_i2c_remove(struct platform_device *pdev)
> +{
> +       struct gxp_i2c_drvdata *drvdata = platform_get_drvdata(pdev);
> +
> +       disable_irq(drvdata->irq);

The i2c core calls disable_irq for us (see i2c_device_shutdown) so you
don't need that here.

In my review I wondered if you needed to do something like this:

+               regmap_update_bits(i2cg_map, GXP_I2CINTEN, 0x00000FFF, 0);

> +       i2c_del_adapter(&drvdata->adapter);
> +
> +       return 0;
> +}
> +