linux-kernel - Re: [PATCH v2 2/2] arm: dts: exynos5422: Add device-tree for Samsung Galaxy S5 (SM-G900H)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51e31914-6b86-b83b-898e-2d2d31a59620@linaro.org>
Date:   Mon, 23 Jan 2023 16:35:44 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Markuss Broks <markuss.broks@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Alim Akhtar <alim.akhtar@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        soc@...nel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] arm: dts: exynos5422: Add device-tree for Samsung
 Galaxy S5 (SM-G900H)

On 21/01/2023 21:19, Markuss Broks wrote:
> Samsung Galaxy S5 (SM-G900H) was sold alongside Samsung Galaxy S5
> with Snapdragon SoC, however the Exynos version features a 3G
> capable Intel modem instead of Qualcomm version featuring LTE modem.
> This phone is based on Exynos5422. Currently, the touchscreen,
> USB, eMMC and the PMIC are enabled in the device-tree.
> 
> Signed-off-by: Markuss Broks <markuss.broks@...il.com>
> ---
>  arch/arm/boot/dts/Makefile                   |   1 +
>  arch/arm/boot/dts/exynos5422-samsung-k3g.dts | 676 +++++++++++++++++++
>  2 files changed, 677 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos5422-samsung-k3g.dts
> 

I gave it a try but dtbs_check complain:

/home/krzk/dev/linux/linux/out/arch/arm/boot/dts/exynos5422-samsung-k3g.dtb:
pinctrl@...00000: 's2mps11-irq-pin', 'touch-int-pin' do not match any of
the regexes: '^(initial|sleep)-state$', '^[a-z0-9-]+-pins$',
'^[a-z]+[0-9]*-gpio-bank$', 'pinctrl-[0-9]+'
	From schema:
/home/krzk/dev/linux/linux/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml


Best regards,
Krzysztof