lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 23 Jan 2023 16:39:51 +0100
From:   Michal Simek <michal.simek@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Lubomir Rintel <lkundrak@...sk>,
        - <devicetree@...r.kernel.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        Michal Simek <michal.simek@...inx.com>,
        Chester Lin <clin@...e.com>, Fugang Duan <fugang.duan@....com>,
        Magnus Damm <magnus.damm@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Pragnesh Patel <pragnesh.patel@...ive.com>,
        Le Ray <erwan.leray@...s.st.com>,
        Peter Korsgaard <jacmet@...site.dk>,
        Tomer Maimon <tmaimon77@...il.com>,
        <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-amlogic@...ts.infradead.org>,
        <linux-riscv@...ts.infradead.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH 05/13] dt-bindings: serial: cdsn,uart: add power-domains



On 1/23/23 16:12, Krzysztof Kozlowski wrote:
> 
> Few Xilinx DTS have power domains in serial node:
> 
>    zynqmp-zc1232-revA.dtb: serial@...00000: Unevaluated properties are not allowed ('power-domains' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   .../devicetree/bindings/serial/cdns,uart.yaml   | 17 ++++++++++++++---
>   1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> index 0c118d5336cc..38925b79cb38 100644
> --- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> @@ -9,9 +9,6 @@ title: Cadence UART Controller
>   maintainers:
>     - Michal Simek <michal.simek@...inx.com>
> 
> -allOf:
> -  - $ref: serial.yaml#
> -
>   properties:
>     compatible:
>       oneOf:
> @@ -46,6 +43,9 @@ properties:
>         port does not use this pin.
>       type: boolean
> 
> +  power-domains:
> +    maxItems: 1
> +
>   required:
>     - compatible
>     - reg
> @@ -53,6 +53,17 @@ required:
>     - clocks
>     - clock-names
> 
> +allOf:
> +  - $ref: serial.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: cdns,uart-r1p8
> +    then:
> +      properties:
> +        power-domains: false
> +
>   unevaluatedProperties: false
> 
>   examples:
> --
> 2.34.1
> 

Reviewed-by: Michal Simek <michal.simek@....com>

btw: I was running it and I have seen that properties are checked only on nodes 
which have status property okay. On disabled nodes properties are not checked. 
Is this standard behavior/setting?

Thanks,
Michal

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ