linux-kernel - Re: [RFT 05/11] ARM: dts: exynos: add ports in HDMI bridge in Exynos4412 Midas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2023 16:34:27 +0100
From:   Henrik Grimler <henrik@...mler.se>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Inki Dae <inki.dae@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Kukjin Kim <kgene@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        replicant@...osl.org, phone-devel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        Martin Jücker <martin.juecker@...il.com>
Subject: Re: [RFT 05/11] ARM: dts: exynos: add ports in HDMI bridge in
 Exynos4412 Midas

Hi,

I see you have already merged this, but FWIW HDMI works as well as
before on exynos4412-i9300, so:

Tested-by: Henrik Grimler <henrik@...mler.se>

Longer explanation: HDMI output only works on i9300 if MHL cable is
attached before device boots, so probably bootloader sets up some
settings that the sii9234 driver does not handle (correctly) if cable
is hot plugged.

Best regards,
Henrik Grimler

On Fri, Jan 20, 2023 at 04:53:58PM +0100, Krzysztof Kozlowski wrote:
> The SII9234 HDMI bridge expects ports property:
> 
>   exynos4412-i9305.dtb: hdmi-bridge@39: 'ports' is a required property
>   exynos4412-i9305.dtb: hdmi-bridge@39: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  arch/arm/boot/dts/exynos4412-midas.dtsi | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
> index 8e1c19a8ad06..a626d33d1330 100644
> --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
> @@ -273,9 +273,16 @@ sii9234: hdmi-bridge@39 {
>  			interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
>  			reg = <0x39>;
>  
> -			port {
> -				mhl_to_hdmi: endpoint {
> -					remote-endpoint = <&hdmi_to_mhl>;
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +
> +					mhl_to_hdmi: endpoint {
> +						remote-endpoint = <&hdmi_to_mhl>;
> +					};
>  				};
>  			};
>  		};
> -- 
> 2.34.1
>