linux-kernel - Re: [PATCH v7 7/7] arm64: dts: mediatek: Initial mt8365-evk support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP2ifjNpPFRGJ+dLJPw4tHP1vApyTeuynA_53V8xNQ9SpaxXnA@mail.gmail.com>
Date:   Mon, 23 Jan 2023 17:10:50 +0100
From:   Bernhard Rosenkränzer <bero@...libre.com>
To:     Matthias Brugger <matthias.bgg@...il.com>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-usb@...r.kernel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        tglx@...utronix.de, maz@...nel.org, lee@...nel.org,
        linus.walleij@...aro.org, chunfeng.yun@...iatek.com,
        gregkh@...uxfoundation.org,
        angelogioacchino.delregno@...labora.com,
        allen-kh.cheng@...iatek.com, nfraprado@...labora.com,
        sean.wang@...iatek.com, zhiyong.tao@...iatek.com
Subject: Re: [PATCH v7 7/7] arm64: dts: mediatek: Initial mt8365-evk support

Hi,

On Fri, Jan 20, 2023 at 11:57 AM Matthias Brugger
<matthias.bgg@...il.com> wrote:
> On 01/01/2023 23:01, Bernhard Rosenkränzer wrote:
> > +             uart0: serial@...02000 {
> > +                     compatible = "mediatek,mt8365-uart", "mediatek,mt6577-uart";
>
> Unfortunately we are missing this compatible in the binding description.

True, overlooked that one.

> > +             ssusb: usb@...01000 {
> > +                     compatible = "mediatek,mt8365-mtu3", "mediatek,mtu3";
>
> Same here.

This is actually added by an earlier patch within this series (5/7),
but since it isn't used anywhere yet, might as well drop it for now,
"mediatek,mtu3" by itself works.

> > +                     usb_host: usb@...00000 {
> > +                             compatible = "mediatek,mt8365-xhci", "mediatek,mtk-xhci";
>
> Same here.

Also added by an earlier patch within the series (6/7), and also not
used anywhere yet.

> > +     systimer: timer@...17000 {
> > +             compatible = "mediatek,mt6795-systimer";
>
> Why don't we use a compatible like
> "mediatek,mt8365-systimer", "mediatek,mt6795-systimer";

That was in an earlier revision and removed (because the binding
description wasn't merged yet). Can add it of course (but then
mediatek,mt8365-uart and friends should probably stay as well).

I'll post a new revision adding it back (along with the binding
description) and add the binding description for mt8365-uart as well
(getting it to the same place mediatek,mt8365-mtu3 and
mediatek,mt8365-xhci are now).
Let me know if you'd prefer a variant that drops mediatek,mt8365-uart,
mediatek,mt8365-mtu3, mediatek,mt8365-xhci and doesn't bring back
mediatek,mt8365-systimer -- either one works for me, the fallbacks are
sufficient to make it work.

ttyl
bero