linux-kernel - Re: [PATCH 6/8] eventfs: adding eventfs lookup, read, open functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230123115404.30f03a37@gandalf.local.home>
Date:   Mon, 23 Jan 2023 11:54:04 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Ajay Kaher <akaher@...are.com>
Cc:     mhiramat@...nel.org, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org, chinglinyu@...gle.com,
        namit@...are.com, srivatsab@...are.com, srivatsa@...il.mit.edu,
        amakhalov@...are.com, vsirnapalli@...are.com, tkundu@...are.com,
        er.ajay.kaher@...il.com
Subject: Re: [PATCH 6/8] eventfs: adding eventfs lookup, read, open
 functions

On Sun, 22 Jan 2023 22:37:05 +0530
Ajay Kaher <akaher@...are.com> wrote:

> +int dcache_dir_open_wrapper(struct inode *inode, struct file *file)
> +{
> +	struct tracefs_inode *ti;
> +	struct eventfs_inode *ei;
> +	struct eventfs_file *ef;
> +	struct inode *f_inode = file_inode(file);
> +	struct dentry *dentry = file_dentry(file);
> +
> +	ti = get_tracefs(f_inode);
> +	if (!(ti->flags & TRACEFS_EVENT_INODE))
> +		return -EINVAL;
> +
> +	ei = ti->private;
> +	list_for_each_entry(ef, &ei->e_top_files, list) {
> +		if (ef->created) {
> +			dget(ef->dentry);
> +			continue;
> +		}
> +
> +		ef->created = true;
> +
> +		inode_lock(dentry->d_inode);

> +		if (ef->ei) 

There's an extra space at the end of the above line.

-- Steve


> +			ef->dentry = eventfs_create_dir(ef->name, ef->mode, dentry,
> +							ef->data, ef->fop, ef->iop, 1);
> +		else
> +			ef->dentry = eventfs_create_file(ef->name, ef->mode, dentry,
> +							 ef->data, ef->fop, 1);
> +		inode_unlock(dentry->d_inode);
> +
> +		if (IS_ERR_OR_NULL(ef->dentry)) {
> +			ef->created = false;
> +		} else {
> +			if (ef->ei)
> +				eventfs_post_create_dir(ef);
> +			ef->dentry->d_fsdata = ef;
> +		}
> +	}
> +	return dcache_dir_open(inode, file);
> +}
> +