linux-kernel - Re: [PATCH 5/5 v7] input: pwm-beeper: handle module unloading properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd8d6f46-9d4a-c74d-6af4-0abbc0c54526@linaro.org>
Date:   Tue, 24 Jan 2023 18:00:52 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Manuel Traut <manuel.traut@...com>, linux-kernel@...r.kernel.org
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Frieder Schrempf <frieder.schrempf@...tron.de>,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 5/5 v7] input: pwm-beeper: handle module unloading
 properly

On 24/01/2023 17:44, Manuel Traut wrote:
> 'input: pwm-beeper: add feature to set volume via sysfs' adds device
> attributes without removing them on error or if the module is unloaded.
> 
> This change removes the device attributes on module unloading or if

Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> registering on the input subsystem fails.
> 
> If the module will be unloaded and loaded again it fails:
> [ 1007.918180] sysfs: cannot create duplicate filename '/devices/platform/buzzer/volume'
> 
> Signed-off-by: Manuel Traut <manuel.traut@...com>
> ---
>  drivers/input/misc/pwm-beeper.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index fe543c4151d6..8ef2937e8f21 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -300,6 +300,7 @@ static int pwm_beeper_probe(struct platform_device *pdev)
>  
>  	error = input_register_device(beeper->input);
>  	if (error) {
> +		sysfs_remove_group(&pdev->dev.kobj, &pwm_beeper_attribute_group);
>  		dev_err(dev, "Failed to register input device: %d\n", error);
>  		return error;
>  	}
> @@ -309,6 +310,17 @@ static int pwm_beeper_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static int pwm_beeper_remove(struct platform_device *pdev)
> +{
> +	struct pwm_beeper *beeper;
> +
> +    beeper = platform_get_drvdata(pdev);

Wrong indentation.

Please run scripts/checkpatch.pl and fix reported warnings.


> +	input_unregister_device(beeper->input);

Best regards,
Krzysztof