linux-kernel - Re: [PATCH AUTOSEL 6.1 15/35] btrfs: stop using write_one_page in btrfs_scratch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230124165716.GS11562@twin.jikos.cz>
Date:   Tue, 24 Jan 2023 17:57:16 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Christoph Hellwig <hch@....de>,
        David Sterba <dsterba@...e.com>, clm@...com,
        josef@...icpanda.com, linux-btrfs@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.1 15/35] btrfs: stop using write_one_page in
 btrfs_scratch_superblock

On Tue, Jan 24, 2023 at 08:41:11AM -0500, Sasha Levin wrote:
> From: Christoph Hellwig <hch@....de>
> 
> [ Upstream commit 26ecf243e407be54807ad67210f7e83b9fad71ea ]
> 
> write_one_page is an awkward interface that expects the page locked and
> ->writepage to be implemented.  Replace that by zeroing the signature
> bytes and synchronize the block device page using the proper bdev
> helpers.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> Reviewed-by: David Sterba <dsterba@...e.com>
> [ update changelog ]
> Signed-off-by: David Sterba <dsterba@...e.com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

Please drop this patch and "btrfs: factor out scratching of one regular
super block" from all stable queues. It's not a fix, only preparatory
work to allow removing write_one_page from MM code.

Commit ids: 0e0078f72be81bbb and 26ecf243e407be54