linux-kernel - Re: [PATCH -next v2 1/3] cacheinfo: Initialize variables in fetch_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9ATCzWu/YjbZPVE@spud>
Date:   Tue, 24 Jan 2023 17:19:07 +0000
From:   Conor Dooley <conor@...nel.org>
To:     Pierre Gondois <pierre.gondois@....com>
Cc:     linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Dan Carpenter <error27@...il.com>,
        kernel test robot <lkp@...el.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Sudeep Holla <sudeep.holla@....com>,
        Palmer Dabbelt <palmer@...osinc.com>,
        Oliver Upton <oliver.upton@...ux.dev>,
        Akihiko Odaki <akihiko.odaki@...nix.com>,
        Gavin Shan <gshan@...hat.com>,
        Jeremy Linton <jeremy.linton@....com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -next v2 1/3] cacheinfo: Initialize variables in
 fetch_cache_info()

On Tue, Jan 24, 2023 at 04:40:46PM +0100, Pierre Gondois wrote:
> Set potentially uninitialized variables to 0. This is particularly
> relevant when CONFIG_ACPI_PPTT is not set.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Link: https://lore.kernel.org/all/202301052307.JYt1GWaJ-lkp@intel.com/
> Reported-by: Dan Carpenter <error27@...il.com>
> Link: https://lore.kernel.org/all/Y86iruJPuwNN7rZw@kili/
> Fixes: 5944ce092b97 ("arch_topology: Build cacheinfo from primary CPU")
> Signed-off-by: Pierre Gondois <pierre.gondois@....com>

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks for the quick respin Pierre :)

> ---
>  drivers/base/cacheinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c
> index 418a18acc8f9..f6573c335f4c 100644
> --- a/drivers/base/cacheinfo.c
> +++ b/drivers/base/cacheinfo.c
> @@ -424,7 +424,7 @@ int allocate_cache_info(int cpu)
>  int fetch_cache_info(unsigned int cpu)
>  {
>  	struct cpu_cacheinfo *this_cpu_ci;
> -	unsigned int levels, split_levels;
> +	unsigned int levels = 0, split_levels = 0;
>  	int ret;
>  
>  	if (acpi_disabled) {
> -- 
> 2.25.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)