linux-kernel - Re: [PATCH/RFC] module: replace module_layout with module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW5XA9GiQ-dtWH8hUkhpTUYAvxegdH3BZ+j7+RfEMqwZJg@mail.gmail.com>
Date:   Tue, 24 Jan 2023 10:01:41 -0800
From:   Song Liu <song@...nel.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        songliubraving@...com, Peter Zijlstra <peterz@...radead.org>,
        linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH/RFC] module: replace module_layout with module_memory

Hi Christoph,

On Sun, Jan 22, 2023 at 10:57 PM Christoph Hellwig <hch@....de> wrote:
>
> On Fri, Jan 20, 2023 at 09:42:26AM -0800, Song Liu wrote:
> > So here are the two versions, both with secondary addr_[min|max] for
> > CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC.
> >
> > v2. Just use mod_mem array:
> > https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git/commit/?h=remotes/song-md/new_module_alloc_build_test_v2
> >
> > v3. mod_mem array and the defines:
> > #define mod_core_text mod_mem[MOD_MEM_TYPE_TEXT]
> > #define mod_core_data mod_mem[MOD_MEM_TYPE_DATA]
> > etc.
> > https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git/commit/?h=remotes/song-md/new_module_alloc_build_test_v3
>
> I find v2 much preferably.  Having magic layouts with different
> access methods is horribly confusing.  It might be a way changes
> things if modifying every caller would be intrusive, but starting
> out that way does not seem like a very good idea.

Thanks for the feedback! I will send a patch based on v2.

Song