linux-kernel - Re: [PATCH] media: imx: imx-media-fim: Replace macro icap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y89cJvIYtg9fkczb@kadam>
Date:   Tue, 24 Jan 2023 07:18:46 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Marco Felsch <m.felsch@...gutronix.de>
Cc:     Brent Pappas <bpappas@...pasbrent.com>, slongerbeam@...il.com,
        festevam@...il.com, p.zabel@...gutronix.de,
        gregkh@...uxfoundation.org, s.hauer@...gutronix.de,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-imx@....com, kernel@...gutronix.de, mchehab@...nel.org,
        shawnguo@...nel.org, linux-arm-kernel@...ts.infradead.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] media: imx: imx-media-fim: Replace macro icap_enabled()
 with function

On Mon, Jan 23, 2023 at 10:51:05PM +0100, Marco Felsch wrote:
> > -#define icap_enabled(fim) ((fim)->icap_flags != IRQ_TYPE_NONE)
> > +static bool icap_enabled(struct imx_media_fim *fim)
> > +{
> > +	return fim->icap_flags != IRQ_TYPE_NONE;
> > +}
> 
> Nit: I would make it inline but recent compiler may do the job for us.
> 

Yeah.  These days we tend to not make things inline.

regards,
dan carpenter

> Reviewed-by: Marco Felsch <m.felsch@...gutronix.de>
> 
> Regards,
>   Marco