| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <b88bacbb-9da2-2175-3f59-7156c3aad4e3@linaro.org>
Date: Tue, 24 Jan 2023 08:52:35 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Rob Herring <robh@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
Olivier Dautricourt <olivierdautricourt@...il.com>,
Stefan Roese <sr@...x.de>, Hector Martin <marcan@...can.st>,
Sven Peter <sven@...npeter.dev>,
Alyssa Rosenzweig <alyssa@...enzweig.io>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Andreas Färber <afaerber@...e.de>,
Manivannan Sadhasivam <mani@...nel.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Viresh Kumar <vireshk@...nel.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Green Wan <green.wan@...ive.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
Masami Hiramatsu <mhiramat@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Maxime Ripard <mripard@...nel.org>,
�er <povik+lin@...ebit.org>,
Peng Fan <peng.fan@....com>,
Paul Cercueil <paul@...pouillou.net>,
- <chuanhua.lei@...el.com>, Long Cheng <long.cheng@...iatek.com>,
Rajesh Gumasta <rgumasta@...dia.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
Biju Das <biju.das.jz@...renesas.com>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Palmer Debbelt <palmer@...ive.com>,
Masahiro Yamada <yamada.masahiro@...ionext.com>,
Amelie Delaunay <amelie.delaunay@...s.st.com>,
Linus Walleij <linus.walleij@...aro.org>,
dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
linux-kernel@...r.kernel.org, asahi@...ts.linux.dev,
linux-tegra@...r.kernel.org, linux-actions@...ts.infradead.org,
linux-arm-msm@...r.kernel.org, linux-riscv@...ts.infradead.org,
linux-stm32@...md-mailman.stormreply.com,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 2/2] dt-bindings: dma: cleanup examples - indentation,
lowercase hex
On 23/01/2023 21:20, Rob Herring wrote:
> On Wed, Jan 18, 2023 at 07:01:44PM +0100, Krzysztof Kozlowski wrote:
>> Cleanup examples:
>> - use 4-space indentation (for cases when it is neither 4 not 2 space),
>> - use lowercase hex.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>> .../bindings/dma/snps,dw-axi-dmac.yaml | 36 +++++++++----------
>> .../bindings/dma/stericsson,dma40.yaml | 4 +--
>> 2 files changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> index 2bedab1f74e0..d34d0fa62ab5 100644
>> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> @@ -113,21 +113,21 @@ additionalProperties: false
>>
>> examples:
>> - |
>> - #include <dt-bindings/interrupt-controller/arm-gic.h>
>> - #include <dt-bindings/interrupt-controller/irq.h>
>> - /* example with snps,dw-axi-dmac */
>> - dmac: dma-controller@...00 {
>> - compatible = "snps,axi-dma-1.01a";
>> - reg = <0x80000 0x400>;
>> - clocks = <&core_clk>, <&cfgr_clk>;
>> - clock-names = "core-clk", "cfgr-clk";
>> - interrupt-parent = <&intc>;
>> - interrupts = <27>;
>> - #dma-cells = <1>;
>> - dma-channels = <4>;
>> - snps,dma-masters = <2>;
>> - snps,data-width = <3>;
>> - snps,block-size = <4096 4096 4096 4096>;
>> - snps,priority = <0 1 2 3>;
>> - snps,axi-max-burst-len = <16>;
>> - };
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> + /* example with snps,dw-axi-dmac */
>> + dmac: dma-controller@...00 {
>
> Drop unused labels while you are here.
Ack
>
>> + compatible = "snps,axi-dma-1.01a";
>> + reg = <0x80000 0x400>;
>> + clocks = <&core_clk>, <&cfgr_clk>;
>> + clock-names = "core-clk", "cfgr-clk";
>> + interrupt-parent = <&intc>;
>> + interrupts = <27>;
>> + #dma-cells = <1>;
>> + dma-channels = <4>;
>> + snps,dma-masters = <2>;
>> + snps,data-width = <3>;
>> + snps,block-size = <4096 4096 4096 4096>;
>> + snps,priority = <0 1 2 3>;
>> + snps,axi-max-burst-len = <16>;
>> + };
>> diff --git a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
>> index 664ee61a00d8..57395a810719 100644
>> --- a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
>> +++ b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
>> @@ -147,9 +147,9 @@ examples:
>> #include <dt-bindings/interrupt-controller/irq.h>
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> #include <dt-bindings/mfd/dbx500-prcmu.h>
>> - dma-controller@...C0000 {
>> + dma-controller@...c0000 {
>> compatible = "stericsson,db8500-dma40", "stericsson,dma40";
>> - reg = <0x801C0000 0x1000>, <0x40010000 0x800>;
>> + reg = <0x801c0000 0x1000>, <0x40010000 0x800>;
>> reg-names = "base", "lcpa";
>> interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>> #dma-cells = <3>;
>
> Indentation?
Ack
Best regards,
Krzysztof
Powered by blists - more mailing lists