linux-kernel - Re: [PATCH 06/15] soc: add Ambarella driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <578e034a-d75f-3b50-76dd-8eb90a127258@microchip.com>
Date:   Tue, 24 Jan 2023 08:46:41 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <me@...ux.beauty>
CC:     <lchen@...arella.com>, <arnd@...db.de>, <heiko@...ech.de>,
        <lkundrak@...sk>, <robert.jarzmik@...e.fr>, <sven@...npeter.dev>,
        <zhuyinbo@...ngson.cn>, <briannorris@...omium.org>,
        <hasegawa-hitomi@...itsu.com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 06/15] soc: add Ambarella driver

Hey,

>>> +++ b/drivers/soc/ambarella/Makefile
>>> @@ -0,0 +1,3 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only
>>> +
>>> +obj-$(CONFIG_ARCH_AMBARELLA) += soc.o
>>
>> The subdirectory is already gated by this symbol, so is there much point
>> gating it on the same one again?
> 
> Yeah, it lookgs kind of redundant now, but I will upstream other drivers after
> this series get merged, which are not gated by this symbol.

You could make the directory by obj-y, and therefore always included,
and have various drivers controlled by their own Kconfig symbols.

Or else, you could leave the directory controlled by ARCH_AMBARELLA
and make the above `obj-y += soc.o` instead, since it's always
going to be built if the directory is included.

Thanks,
Conor.