linux-kernel - Re: [PATCH 11/13] dt-bindings: serial: restrict possible child node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Jan 2023 10:05:27 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>, - <devicetree@...r.kernel.org>,
        linux-riscv@...ts.infradead.org,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Tomer Maimon <tmaimon77@...il.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Peter Korsgaard <jacmet@...site.dk>,
        Chester Lin <clin@...e.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-stm32@...md-mailman.stormreply.com,
        Kevin Hilman <khilman@...libre.com>,
        linux-kernel@...r.kernel.org, Fugang Duan <fugang.duan@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Fabio Estevam <festevam@...il.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Le Ray <erwan.leray@...s.st.com>,
        Michal Simek <michal.simek@...inx.com>,
        Lubomir Rintel <lkundrak@...sk>,
        Jerome Brunet <jbrunet@...libre.com>,
        Magnus Damm <magnus.damm@...il.com>,
        Pragnesh Patel <pragnesh.patel@...ive.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-amlogic@...ts.infradead.org,
        NXP Linux Team <linux-imx@....com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 11/13] dt-bindings: serial: restrict possible child node
 names

On 24/01/2023 00:05, Rob Herring wrote:
> 
> On Mon, 23 Jan 2023 16:13:00 +0100, Krzysztof Kozlowski wrote:
>> The re-usable serial.yaml schema matches every property with ".*"
>> pattern, thus any other schema referencing it will not report unknown
>> (unevaluated) properties.  This hides several wrong properties.  It is
>> a limitation of dtschema, thus provide a simple workaround: expect
>> children to be only of few names matching upstream usage (Bluetooth,
>> GNSS, GPS and MCU).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>  Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bus/intel,ixp4xx-expansion-bus-controller.example.dtb: serial@1,0: Unevaluated properties are not allowed ('intel,ixp4xx-eb-byte-access', 'intel,ixp4xx-eb-cycle-type', 'intel,ixp4xx-eb-t3', 'intel,ixp4xx-eb-write-enable' were unexpected)
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/8250.yaml

Eh, this is not trivial to solve. The
"intel,ixp4xx-expansion-bus-controller.yaml" bindings add properties to
children nodes, just like spi-peripheral-props:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/bus/intel,ixp4xx-expansion-bus-controller.yaml?h=v6.2-rc5#n147

Any node can be there:
1. serial, which was broken since beginning but errors not visible,
2. flash, which work fine just because mtd-physmap.yaml allows it,
3. more?

Existing DTS of this ixp4xx controller have different nodes, for example:
flash, shared-dma-pool, ns8250, arcom,vulcan-gpio, maxim,max6369:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/intel-ixp42x-arcom-vulcan.dts?h=v6.2-rc5#n40

Probably we need expansion-bus-controller-peripheral-props.yaml and
include it in every possible child. Does it sound reasonable?

Best regards,
Krzysztof