linux-kernel - Re: [PATCH RFC] tools/nolibc: Add gitignore to avoid git complaints about sysroot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230124011257.GC2948950@paulmck-ThinkPad-P17-Gen-1>
Date:   Mon, 23 Jan 2023 17:12:57 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Ammar Faizi <ammarfaizi2@...weeb.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Willy Tarreau <w@....eu>, Sven Schnelle <svens@...ux.ibm.com>
Subject: Re: [PATCH RFC] tools/nolibc: Add gitignore to avoid git complaints
 about sysroot

On Tue, Jan 24, 2023 at 08:06:00AM +0700, Ammar Faizi wrote:
> On Mon, Jan 23, 2023 at 04:47:07PM -0800, Paul E. McKenney wrote:
> > Testing of nolibc can produce a tools/include/nolibc/sysroot file, which
> > is not known to git.  Because it is automatically generated, there is no
> > reason for it to be known to git.  Therefore, add a .gitignore to remove
> > it from git's field of view.
> 
> Yeah, I hit the same "git status" complaint and have a pending patch
> for that too:
> 
> https://github.com/ammarfaizi2/linux-block/commit/89bfe86a03c173863de12.patch
> 
> ^ I'll drop this one.

Actually, why don't we take yours?  Either way, I have to change something
per your feedback below.

No hurry, send it along when you normally would have.

							Thanx, Paul

> > Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> > Cc: Willy Tarreau <w@....eu>
> > Cc: Ammar Faizi <ammarfaizi2@...weeb.org>
> > Cc: Sven Schnelle <svens@...ux.ibm.com>
> > 
> > diff --git a/tools/include/nolibc/.gitignore b/tools/include/nolibc/.gitignore
> > new file mode 100644
> > index 0000000000000..dea22eaaed2ba
> > --- /dev/null
> > +++ b/tools/include/nolibc/.gitignore
> > @@ -0,0 +1 @@
> > +sysroot
> 
> Small nit about the naming, not so much important, but the common
> pattern for directory has a trailing slash. So, I would write
> "sysroot/".
> 
> ".gitignore" and "tools/testing/selftests/.gitignore" do that too :-)
> 
> Reviewed-by: Ammar Faizi <ammarfaizi2@...weeb.org>
> 
> Thanks!
> 
> -- 
> Ammar Faizi
>