[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1dbd558a-92b7-77ed-1bbe-0f421547bf54@arm.com>
Date: Tue, 24 Jan 2023 11:08:32 +0000
From: Suzuki K Poulose <suzuki.poulose@....com>
To: James Clark <james.clark@....com>,
linux-perf-users@...r.kernel.org, acme@...nel.org
Cc: linux-kernel@...r.kernel.org,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Mike Leach <mike.leach@...aro.org>,
Leo Yan <leo.yan@...aro.org>,
John Garry <john.g.garry@...cle.com>,
Will Deacon <will@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>, coresight@...ts.linaro.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] perf: cs-etm: Improve missing sink warning message
On 24/01/2023 11:02, James Clark wrote:
> Make the sink error message more similar to the event error message that
> reminds about missing kernel support. The available sinks are also
> determined by the hardware so mention that too.
>
> Also, usually it's not necessary to specify the sink, so add that as a
> hint.
>
> Now the error for a made up sink looks like this:
>
> $ perf record -e cs_etm/@.../
> Couldn't find sink "abc" on event cs_etm/@.../.
> Missing kernel or device support?
>
> Hint: An appropriate sink will be picked automatically if one isn't is specified.
>
> For any error other than ENOENT, the same message as before is
> displayed.
>
> Signed-off-by: James Clark <james.clark@....com>
Acked-by: Suzuki K Poulose <suzuki.poulose@....com>
Powered by blists - more mailing lists