linux-kernel - Re: [PATCH 2/3 v6] input: pwm-beeper: add feature to set volume level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcdaaf94-b879-b171-f24a-82647a1ef9a6@kernel.org>
Date:   Tue, 24 Jan 2023 12:29:27 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Manuel Traut <manuel.traut@...com>, linux-kernel@...r.kernel.org
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Frieder Schrempf <frieder.schrempf@...tron.de>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH 2/3 v6] input: pwm-beeper: add feature to set volume level

On 24/01/2023 12:13, Manuel Traut wrote:
> This patch adds the documentation for the devicetree bindings to set
> the volume levels.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@...eet.de>

I think it is kontron.de now.

> Acked-by: Rob Herring <robh@...nel.org>

This misses your SoB.

> ---
>  .../devicetree/bindings/input/pwm-beeper.txt          | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.txt b/Documentation/devicetree/bindings/input/pwm-beeper.txt
> index 8fc0e48c20db..93cab5eee9f2 100644
> --- a/Documentation/devicetree/bindings/input/pwm-beeper.txt
> +++ b/Documentation/devicetree/bindings/input/pwm-beeper.txt
> @@ -9,6 +9,15 @@ Required properties:
>  Optional properties:
>  - amp-supply: phandle to a regulator that acts as an amplifier for the beeper
>  - beeper-hz:  bell frequency in Hz
> +- volume-levels: Array of PWM duty cycle values that correspond to
> +      linear volume levels. These need to be in the range of 0 to 500,
> +      while 0 means 0% duty cycle (mute) and 500 means 50% duty cycle
> +      (max volume).
> +      Please note that the actual volume of most beepers is highly
> +      non-linear, which means that low volume levels are probably somewhere
> +      in the range of 1 to 30 (0.1-3% duty cycle).
> +- default-volume-level: the default volume level (index into the
> +      array defined by the "volume-levels" property)

The bindings should be converted to DT schema first and then new
properties added.

Best regards,
Krzysztof