linux-kernel - Re: [PATCH] media: atomisp: fix build error, use vb2 interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67cf4353-5bf5-d132-0b64-76533e6f3216@redhat.com>
Date:   Tue, 24 Jan 2023 14:53:34 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     kernel test robot <lkp@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] media: atomisp: fix build error, use vb2 interfaces

Hi Randy,

On 1/24/23 02:30, Randy Dunlap wrote:
> The atomisp driver uses functions that are provided by VIDEOBUF2_VMALLOC
> instead of VIDEOBUF_VMALLOC, so change the 'select' so that the correct
> interfaces are built.
> 
> ld: drivers/staging/media/atomisp/pci/atomisp_fops.o: in function `atomisp_init_pipe':
> drivers/staging/media/atomisp/pci/atomisp_fops.c:649: undefined reference to `vb2_vmalloc_memops'
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 9d4fa1a16b28 ("media: atomisp: cleanup directory hierarchy")
> Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>
> Cc: linux-media@...r.kernel.org

Thank you for the patch, the same patch was already posted by Arnd
a while ago:

https://lore.kernel.org/linux-media/20230104082212.3770415-1-arnd@kernel.org/

but this has unfortunately not found its way to Linus' tree yet.

Regards,

Hans


> ---
>  drivers/staging/media/atomisp/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -- a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig
> --- a/drivers/staging/media/atomisp/Kconfig
> +++ b/drivers/staging/media/atomisp/Kconfig
> @@ -14,7 +14,7 @@ config VIDEO_ATOMISP
>  	depends on VIDEO_DEV && INTEL_ATOMISP
>  	depends on PMIC_OPREGION
>  	select IOSF_MBI
> -	select VIDEOBUF_VMALLOC
> +	select VIDEOBUF2_VMALLOC
>  	select VIDEO_V4L2_SUBDEV_API
>  	help
>  	  Say Y here if your platform supports Intel Atom SoC
>