[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y8/n1AdBwbYqp8lX@nvidia.com>
Date: Tue, 24 Jan 2023 10:14:44 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: David Howells <dhowells@...hat.com>
Cc: John Hubbard <jhubbard@...dia.com>,
Al Viro <viro@...iv.linux.org.uk>,
Christoph Hellwig <hch@...radead.org>,
Matthew Wilcox <willy@...radead.org>,
Jens Axboe <axboe@...nel.dk>, Jan Kara <jack@...e.cz>,
Jeff Layton <jlayton@...nel.org>,
Logan Gunthorpe <logang@...tatee.com>,
linux-fsdevel@...r.kernel.org, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
linux-mm@...ck.org
Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down
On Tue, Jan 24, 2023 at 02:11:50PM +0000, David Howells wrote:
> Jason Gunthorpe <jgg@...dia.com> wrote:
>
> > if (cleanup_flags & PAGE_CLEANUP_UNPIN)
> > gup_put_folio(folio, 1, true);
> > else if (cleanup_flags & PAGE_CLEANUP_PUT)
> > gup_put_folio(folio, 1, false);
>
> gup_put_folio() doesn't take a bool - it takes FOLL_PIN and FOLL_GET:
My point was to change that to take a 'bool unpin' because FOLL_PIN is
not to be used outside gup.c
Jason
Powered by blists - more mailing lists