linux-kernel - Re: [PATCH v4 23/24] integrity/powerpc: Improve error handling & reporting when loading certs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8146e42b3d0a6d361035fa49aa2dd2fb7539363.camel@linux.ibm.com>
Date:   Tue, 24 Jan 2023 10:42:05 -0500
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Andrew Donnellan <ajd@...ux.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-integrity@...r.kernel.org
Cc:     gregkh@...uxfoundation.org, gcwilson@...ux.ibm.com,
        linux-kernel@...r.kernel.org, nayna@...ux.ibm.com,
        ruscur@...sell.cc, mpe@...erman.id.au, gjoyce@...ux.ibm.com,
        sudhakar@...ux.ibm.com, bgray@...ux.ibm.com, erichte@...ux.ibm.com,
        joel@....id.au
Subject: Re: [PATCH v4 23/24] integrity/powerpc: Improve error handling &
 reporting when loading certs

On Fri, 2023-01-20 at 18:43 +1100, Andrew Donnellan wrote:
> From: Russell Currey <ruscur@...sell.cc>
> 
> A few improvements to load_powerpc.c:
> 
>  - include integrity.h for the pr_fmt()
>  - move all error reporting out of get_cert_list()
>  - use ERR_PTR() to better preserve error detail
>  - don't use pr_err() for missing keys
> 
> Signed-off-by: Russell Currey <ruscur@...sell.cc>
> Signed-off-by: Andrew Donnellan <ajd@...ux.ibm.com>

Thanks,

Reviewed-by: Mimi Zohar <zohar@...ux.ibm.com>