linux-kernel - Re: [PATCH] dt-bindings: usb: samsung,exynos-dwc3: allow unit address in DTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230125211329.GA2899932-robh@kernel.org>
Date:   Wed, 25 Jan 2023 15:13:29 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: samsung,exynos-dwc3: allow unit
 address in DTS

On Wed, Jan 25, 2023 at 06:59:43PM +0100, Krzysztof Kozlowski wrote:
> The Samsung Exynos SoC USB 3.0 DWC3 Controller is a simple wrapper of
> actual DWC3 Controller device node.  It handles necessary Samsung
> Exynos-specific resources (regulators, clocks), but does not have its
> own MMIO address space.
> 
> However neither simple-bus bindings nor dtc W=1 accept device nodes in
> soc@ node which do not have unit address.  Therefore allow using
> the address space of child device (actual DWC3 Controller) as the
> wrapper's address.

The correct fix is 'ranges' should have a value. Though the whole 
wrapper thing when there are no registers I dislike...

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> DTS fixes are here:
> https://lore.kernel.org/linux-samsung-soc/20230125175751.675090-1-krzysztof.kozlowski@linaro.org/T/#t
> ---
>  .../devicetree/bindings/usb/samsung,exynos-dwc3.yaml        | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> index 6b9a3bcb3926..a94b1926dda0 100644
> --- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> @@ -29,6 +29,9 @@ properties:
>  
>    ranges: true
>  
> +  reg:
> +    maxItems: 1
> +
>    '#size-cells':
>      const: 1
>  
> @@ -108,8 +111,9 @@ examples:
>      #include <dt-bindings/clock/exynos5420.h>
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
>  
> -    usb {
> +    usb-wrapper@...00000 {
>          compatible = "samsung,exynos5250-dwusb3";
> +        reg = <0x12000000 0x10000>;
>          #address-cells = <1>;
>          #size-cells = <1>;
>          ranges;
> -- 
> 2.34.1
>