linux-kernel - Re: [PATCH 1/2] perf/tracing: Use stage6 of tracing to not duplicate macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9Dzczg7xZTTAnyp@hirez.programming.kicks-ass.net>
Date:   Wed, 25 Jan 2023 10:16:35 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linyu Yuan <quic_linyyuan@...cinc.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, bpf@...r.kernel.org,
        Frederic Weisbecker <fweisbec@...il.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 1/2] perf/tracing: Use stage6 of tracing to not duplicate
 macros

On Tue, Jan 24, 2023 at 03:22:39PM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@...dmis.org>
> 
> The perf events are created by the same macro magic as tracefs trace
> events are. But to hook into perf, it has its own code. It duplicates many
> of the same macros as the tracefs macros and this is an issue because it
> misses bug fixes as well as any new enhancements that come with the other
> trace macros.
> 
> As the trace macros have been put into their own staging files, have perf
> take advantage of this and use the tracefs stage 6 macros that the "fast
> assign" portion of the trace event macro uses.
> 
> Link: https://lore.kernel.org/lkml/1671181385-5719-1-git-send-email-quic_linyyuan@quicinc.com/
> 
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Ingo Molnar <mingo@...e.hu>
> Reported-by: Linyu Yuan <quic_linyyuan@...cinc.com>
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>