linux-kernel - RE: [PATCH 3/3] arm64: dts: renesas: v2mevk2: Add uSD card and eMMC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYWPR01MB8775E63B3C3F5E0F3AAD2BBEC2CE9@TYWPR01MB8775.jpnprd01.prod.outlook.com>
Date:   Wed, 25 Jan 2023 15:09:26 +0000
From:   Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Jacopo Mondi <jacopo@...ndi.org>
Subject: RE: [PATCH 3/3] arm64: dts: renesas: v2mevk2: Add uSD card and eMMC
 support

Hi Geert,

Thanks for your feedback!

> 
> Hi Fabrizio,
> 
> On Wed, Jan 18, 2023 at 3:48 PM Fabrizio Castro
> <fabrizio.castro.jz@...esas.com> wrote:
> > The RZ/V2M EVK comes with a slot for a uSD card, and an eMMC.
> > Add support for the both of them.
> >
> > Please note that the pinctrl driver for RZ/V2M doesn't support
> > interrupts yet, therefore the card detect pin has been connected
> > to the SDHI IP directly in this patch.
> > We'll connect the card detect pin to its corresponding GPIO when
> > we'll have driver support for interrupts in the RZ/V2M pinctrl
> > driver.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts
> 
> > @@ -50,6 +81,22 @@ phy0: ethernet-phy@0 {
> >         };
> >  };
> >
> > +&emmc {
> > +       pinctrl-0 = <&emmc_pins>;
> > +       pinctrl-1 = <&emmc_pins>;
> > +       pinctrl-names = "default", "state_uhs";
> > +
> > +       vmmc-supply = <&reg_3v3>;
> > +       vqmmc-supply = <&reg_1v8>;
> > +       bus-width = <8>;
> > +       mmc-hs200-1_8v;
> > +       non-removable;
> 
> Does this need "no-sd" and "no-sdio"?

I totally missed that.
I'll add those, retest, and I'll update the patch.

> 
> > +       fixed-emmc-driver-type = <1>;
> > +       max-frequency = <200000000>;
> > +       status = "okay";
> > +};
> > +
> > +
> >  &extal_clk {
> >         clock-frequency = <48000000>;
> >  };
> > @@ -78,6 +125,68 @@ i2c2_pins: i2c2 {
> >                 pinmux = <RZV2M_PORT_PINMUX(3, 8, 2)>, /* SDA */
> >                          <RZV2M_PORT_PINMUX(3, 9, 2)>; /* SCL */
> >         };
> > +
> > +       sdhi0_pins: sd0 {
> 
> [...]
> 
> > +       };
> > +
> > +       sdhi0_pins_uhs: sd0_uhs {
> 
> [...]
> 
> > +       };
> > +
> > +       emmc_pins: emmc {
> 
> Please move up to preserve sort order.

I'll fix that in the new version of the patch.

Thanks,
Fab

> 
> The rest LGTM, so with the above clarified/fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a
> hacker. But
> when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds