linux-kernel - RE: [PATCH v1] KVM: destruct kvm_io_device while unregistering it from kvm_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DS0PR11MB6373545E338020F96CF9F57BDCCE9@DS0PR11MB6373.namprd11.prod.outlook.com>
Date:   Wed, 25 Jan 2023 02:38:12 +0000
From:   "Wang, Wei W" <wei.w.wang@...el.com>
To:     "Christopherson,, Sean" <seanjc@...gle.com>
CC:     "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        柳菁峰 <liujingfeng@...nxin.com>
Subject: RE: [PATCH v1] KVM: destruct kvm_io_device while unregistering it
 from kvm_io_bus

On Tuesday, January 24, 2023 7:25 AM, Sean Christopherson wrote:
> > -	kfree(bus);
> > -	return new_bus ? 0 : -ENOMEM;
> > +	kvm_iodevice_destructor(dev);
> > +	return 0;
> 
> Unless I'm misreading things, this path leaks "bus".

Right, should keep the kfree above.

> Given that that intent is to send the fix for stable, that this is as much a
> cleanup as it is a bug fix, and that it's not super trivial, I'm inclined to queue
> my patch and then land this on top as cleanup.

Sounds good to me.