[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230126174119.000056da@Huawei.com>
Date: Thu, 26 Jan 2023 17:41:19 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Markuss Broks <markuss.broks@...il.com>
CC: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
<linux-kernel@...r.kernel.org>,
Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Zhigang Shi <Zhigang.Shi@...eon.com>,
Dmitry Osipenko <dmitry.osipenko@...labora.com>,
Paul Gazzillo <paul@...zz.com>,
Shreeya Patel <shreeya.patel@...labora.com>,
<linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/2] iio: light: Add support for AMS TCS3490 light
sensor
On Thu, 26 Jan 2023 17:54:56 +0200
Markuss Broks <markuss.broks@...il.com> wrote:
> Hi Andy,
>
> On 1/24/23 12:22, Andy Shevchenko wrote:
> > On Tue, Jan 24, 2023 at 01:10:25AM +0200, Markuss Broks wrote:
> >> Add a driver for AMS TCS3490 Color Light-to-Digital Converter. This
> >> device provides color and IR (red, green, blue, clear and IR) light
> >> sensing. The color sensing can be used for light source detection and
> >> color temperature measurements.
> > ...
> >
> >> +AMS TCS3490 DRIVER
> >> +M: Markuss Broks <markuss.broks@...il.com>
> >> +L: linux-iio@...r.kernel.org
> >> +S: Maintained
> >> +F: Documentation/devicetree/bindings/iio/light/ams,tcs3490.yaml
> > Shouldn't actually be added with the schema patch?
> >
> >> +F: drivers/iio/light/tcs3490.c
> > I dunno what's the rules but it feels a bit inconsistent in case the schema
> > will leave while driver got, for example, rewritten (as brand new) and reverted
> > (as old one). In such (quite unlikely) circumstances we may end up with the
> > dangling file.
> >
> > Rob, Krzysztof, Jonathan, what is yours take from this?
Ideal is update the file listing as files are added, but I rarely care
enough to fix it up or complain as the patches almost always go
together.
Powered by blists - more mailing lists