linux-kernel - RE: [PATCH v2] selftests: amd-pstate: Don't delete source files via Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <008501d931d7$aaba8360$002f8a20$@telus.net>
Date:   Thu, 26 Jan 2023 14:43:53 -0800
From:   "Doug Smythies" <dsmythies@...us.net>
To:     "'Shuah Khan'" <skhan@...uxfoundation.org>,
        "'Huang Rui'" <ray.huang@....com>, <li.meng@....com>
Cc:     <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        "'Rafael J. Wysocki'" <rafael@...nel.org>,
        <linux-kselftest@...r.kernel.org>,
        "Doug Smythies" <dsmythies@...us.net>, <sedat.dilek@...il.com>
Subject: RE: [PATCH v2] selftests: amd-pstate: Don't delete source files via Makefile

On 2023.01.25 09:03 Shuah Khan wrote:
> On 1/21/23 09:41, Doug Smythies wrote:
>> Revert the portion of a recent Makefile change that incorrectly
>> deletes source files when doing "make clean".
>> 
>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
>> Reported-by: Sedat Dilek <sedat.dilek@...il.com>
>> Tested-by: Sedat Dilek <sedat.dilek@...il.com>
>> Reviewed-by: Sedat Dilek <sedat.dilek@...il.com>
>> Acked-by: Huang Rui <ray.huang@....com>
>> Signed-off-by: Doug Smythies <dsmythies@...us.net>
>> ---
>> v2: fix address list.
>> ---
>>   tools/testing/selftests/amd-pstate/Makefile | 5 -----
>>   1 file changed, 5 deletions(-)
>> 
>> diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
>> index 5f195ee756d6..5fd1424db37d 100644
>> --- a/tools/testing/selftests/amd-pstate/Makefile
>> +++ b/tools/testing/selftests/amd-pstate/Makefile
>> @@ -7,11 +7,6 @@ all:
>>   uname_M := $(shell uname -m 2>/dev/null || echo not)
>>   ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>> 
>> -ifeq (x86,$(ARCH))
>> -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
>> -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
>> -endif
>> -
>
> This looks good - Do you need these files to run this test and if so
> do these need to installed when the test is run on a test system?

I do not know.
It is a question for the AMD people.

> Now applied to linux-kselftest fixes. I will send this up for the next
> rc.

Thank you
... Doug