[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <099e9e5b-88dd-ae5f-307d-6ea9f16586f1@intel.com>
Date: Thu, 26 Jan 2023 16:24:43 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Robert Richter <rrichter@....com>,
Alison Schofield <alison.schofield@...el.com>,
Vishal Verma <vishal.l.verma@...el.com>,
Ira Weiny <ira.weiny@...el.com>,
Ben Widawsky <bwidawsk@...nel.org>,
Dan Williams <dan.j.williams@...el.com>
Cc: Jonathan Cameron <jonathan.cameron@...wei.com>,
linux-cxl@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxl/mbox: Add debug messages for supported mailbox
commands
On 1/19/23 6:04 AM, Robert Richter wrote:
> Only unsupported mailbox commands are reported in debug messages. A
> list of supported commands is useful too. Change debug messages to
> also report the opcodes of supported commands.
>
> On that occasion also add missing trailing newlines.
>
> Signed-off-by: Robert Richter <rrichter@....com>
Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> ---
> drivers/cxl/core/mbox.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index a48ade466d6a..ffa9f84c2dce 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -629,11 +629,12 @@ static void cxl_walk_cel(struct cxl_dev_state *cxlds, size_t size, u8 *cel)
>
> if (!cmd) {
> dev_dbg(cxlds->dev,
> - "Opcode 0x%04x unsupported by driver", opcode);
> + "Opcode 0x%04x unsupported by driver\n", opcode);
> continue;
> }
>
> set_bit(cmd->info.id, cxlds->enabled_cmds);
> + dev_dbg(cxlds->dev, "Opcode 0x%04x supported by driver\n", opcode);
> }
> }
>
>
> base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
Powered by blists - more mailing lists