linux-kernel - Re: [PATCH] genirq/msi: Fix fwnode leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a625emxr.wl-maz@kernel.org>
Date:   Thu, 26 Jan 2023 08:10:08 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH] genirq/msi: Fix fwnode leak

On Wed, 25 Jan 2023 23:13:48 +0000,
Alex Williamson <alex.williamson@...hat.com> wrote:
> 
> kmemleak is reporting pairs of leaked buffers when PCI devices are
> unbound from their drivers.  One of these buffers contains the name of
> the interrupt as generated for the msi_domain_template bundle in
> msi_create_device_irq_domain().  This name is passed through
> irq_domain_alloc_named_fwnode(), where an irqchip_rwid is allocated,
> along with a separate allocation via kasprintf() for another copy of
> the name.  These are the two leaked buffers.
> 
> Resolve this by adding the missing call to irq_domain_free_fwnode() in
> msi_remove_device_irq_domain().
> 
> Fixes: 27a6dea3ebaa ("genirq/msi: Provide msi_create/free_device_irq_domain()")
> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>

Thomas has already queued this:

commit ac8f29aef2f1695956ff6773b33f975290437f29 (tip/irq/urgent)
Author: Jason Gunthorpe <jgg@...pe.ca>
Date:   Tue Jan 17 15:16:17 2023 -0400

    genirq/msi: Free the fwnode created by msi_create_device_irq_domain()

which I assume will make it into Linus' tree shortly.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.