linux-kernel - Re: [PATCH 4.14/4.19/5.4/5.10/5.15 1/1] fs: reiserfs: remove useless new_opts in reiserfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9JEM9toMBcEfDak@kroah.com>
Date:   Thu, 26 Jan 2023 10:13:23 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Fedor Pchelkin <pchelkin@...ras.ru>
Cc:     stable@...r.kernel.org, Jan Kara <jack@...e.cz>,
        Dongliang Mu <mudongliangabcd@...il.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        David Howells <dhowells@...hat.com>,
        reiserfs-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH 4.14/4.19/5.4/5.10/5.15 1/1] fs: reiserfs: remove useless
 new_opts in reiserfs_remount

On Thu, Jan 26, 2023 at 11:58:46AM +0300, Fedor Pchelkin wrote:
> From: Dongliang Mu <mudongliangabcd@...il.com>
> 
> commit 81dedaf10c20959bdf5624f9783f408df26ba7a4 upstream.
> 
> Since the commit c3d98ea08291 ("VFS: Don't use save/replace_mount_options
> if not using generic_show_options") eliminates replace_mount_options
> in reiserfs_remount, but does not handle the allocated new_opts,
> it will cause memory leak in the reiserfs_remount.
> 
> Because new_opts is useless in reiserfs_mount, so we fix this bug by
> removing the useless new_opts in reiserfs_remount.
> 
> Fixes: c3d98ea08291 ("VFS: Don't use save/replace_mount_options if not using generic_show_options")
> Link: https://lore.kernel.org/r/20211027143445.4156459-1-mudongliangabcd@gmail.com
> Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com>
> Signed-off-by: Jan Kara <jack@...e.cz>
> Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>
> ---
>  fs/reiserfs/super.c | 6 ------
>  1 file changed, 6 deletions(-)

Now queued up, thanks.

greg k-h