[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f70c9b67-5284-cd6a-7360-92a883bf9bb5@redhat.com>
Date: Thu, 26 Jan 2023 10:32:05 +0100
From: David Hildenbrand <david@...hat.com>
To: David Howells <dhowells@...hat.com>,
Al Viro <viro@...iv.linux.org.uk>,
Christoph Hellwig <hch@...radead.org>
Cc: Matthew Wilcox <willy@...radead.org>, Jens Axboe <axboe@...nel.dk>,
Jan Kara <jack@...e.cz>, Jeff Layton <jlayton@...nel.org>,
Jason Gunthorpe <jgg@...dia.com>,
Logan Gunthorpe <logang@...tatee.com>,
linux-fsdevel@...r.kernel.org, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Christoph Hellwig <hch@....de>,
John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with
BIO_PAGE_REFFED with inverted logic
On 25.01.23 22:06, David Howells wrote:
> From: Christoph Hellwig <hch@....de>
>
> Replace BIO_NO_PAGE_REF with a BIO_PAGE_REFFED flag that has the inverted
> meaning is only set when a page reference has been acquired that needs to
> be released by bio_release_pages().
>
> Signed-off-by: David Howells <dhowells@...hat.com>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Reviewed-by: John Hubbard <jhubbard@...dia.com>
> cc: Al Viro <viro@...iv.linux.org.uk>
> cc: Jens Axboe <axboe@...nel.dk>
> cc: Jan Kara <jack@...e.cz>
> cc: Matthew Wilcox <willy@...radead.org>
> cc: Logan Gunthorpe <logang@...tatee.com>
> cc: linux-block@...r.kernel.org
> ---
Oh, and I agree with a previous comment that this patch should also hold
a Signed-off-by from Christoph above your Signed-off-by, if he is
mentioned as the author via "From:".
I remember stumbling over that in submitting-patches.rst ...
--
Thanks,
David / dhildenb
Powered by blists - more mailing lists