[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e7d476d7-e201-86a3-9683-c2a559fc2f5b@redhat.com>
Date: Thu, 26 Jan 2023 10:52:19 +0100
From: David Hildenbrand <david@...hat.com>
To: David Howells <dhowells@...hat.com>
Cc: Al Viro <viro@...iv.linux.org.uk>,
Christoph Hellwig <hch@...radead.org>,
Matthew Wilcox <willy@...radead.org>,
Jens Axboe <axboe@...nel.dk>, Jan Kara <jack@...e.cz>,
Jeff Layton <jlayton@...nel.org>,
Jason Gunthorpe <jgg@...dia.com>,
Logan Gunthorpe <logang@...tatee.com>,
linux-fsdevel@...r.kernel.org, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Christoph Hellwig <hch@....de>,
John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH v10 1/8] iov_iter: Define flags to qualify page
extraction.
On 26.01.23 10:49, David Howells wrote:
> David Hildenbrand <david@...hat.com> wrote:
>
>> Just a note that the usage of new __bitwise types instead of "unsigned" is
>> encouraged for flags.
>>
>> See rmap_t in include/linux/rmap.h as an example.
>
> Hmmm... rmap_t really ought to be unsigned int.
Not sure if that particularly matters here in practice, ... anyhow
$ git grep "typedef int" | grep __bitwise | wc -l
27
$ git grep "typedef unsigned" | grep __bitwise | wc -l
23
So chose what you prefer ;)
--
Thanks,
David / dhildenb
Powered by blists - more mailing lists