linux-kernel - Re: [PATCH v1 1/1] usb: gadget: Use correct APIs and data types for UUID handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9JSrWafclaTmLwP@smile.fi.intel.com>
Date:   Thu, 26 Jan 2023 12:15:09 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jó Ágila Bitsch <jgilab@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] usb: gadget: Use correct APIs and data types for
 UUID handling

On Wed, Jan 25, 2023 at 10:54:58PM +0100, Jó Ágila Bitsch wrote:
> On Wed, Jan 25, 2023 at 9:01 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > On Wed, Jan 25, 2023 at 06:31:36PM +0100, Jó Ágila Bitsch wrote:
> > > On Wed, Jan 25, 2023 at 3:34 PM Andy Shevchenko
> > > <andriy.shevchenko@...ux.intel.com> wrote:

...

> > > I compiled and tested your patch in my test setup and it works perfectly.
> >
> > Thanks for the testing. According to Submitting Patches documentation
> > you can provide a formal Tested-by tag.
> 
> Thanks for pointing this out to me.
> 
> I'm not really sure how to do that though.
> On https://docs.kernel.org/process/submitting-patches.html#reviewer-s-statement-of-oversight,
> it says:
> > Both Tested-by and Reviewed-by tags, once received on mailing list from tester or reviewer, should be added by author to the applicable patches when sending next versions.
> 
> So I guess you could do that at your convenience on any next version.

In mine I can only do if you give me that tag. Till this
line the tag is not given, but...

> Or is it already ok, if I just add the following line in my comment?

...this is what is expected to have.

> Tested-By: Jó Ágila Bitsch <jgilab@...il.com>

And now _if_ I need a new version I will bear this with it. Otherwise
maintainer, who picks up the patch, takes care of gathering these all
together.

> I'm still quite a newbie in the kernel development community, so
> thanks for bearing with my ignorance :-)

So far you are doing good, thanks!

-- 
With Best Regards,
Andy Shevchenko