linux-kernel - Re: [PATCH 4/8] gpiolib: remove gpio_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9KFENOgVGC2bUAj@smile.fi.intel.com>
Date:   Thu, 26 Jan 2023 15:50:08 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     linux-gpio@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] gpiolib: remove gpio_set_debounce

On Thu, Jan 26, 2023 at 02:27:57PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> gpio_set_debounce() only has a single user, which is trivially
> converted to gpiod_set_debounce().

Also need to mention the gpio_cansleep() removal.

P.S. Fun fact that I was yesterday thinking about the pretty much
the same change, except intrusive conversion of the user.

...

>  Documentation/driver-api/gpio/legacy.rst |  2 --

Documentation/translations/zh_CN/driver-api/gpio/legacy.rst:222:                gpio_set_debounce()
Documentation/translations/zh_TW/gpio.txt:229:  gpio_set_debounce()


>  drivers/input/touchscreen/ads7846.c      | 24 +++++++++++++-----------
>  include/linux/gpio.h                     | 22 ----------------------

...

>  #include <linux/of_gpio.h>

Do we need this?

>  #include <linux/of_device.h>
> +#include <linux/gpio/consumer.h>

>  #include <linux/gpio.h>

And this?

-- 
With Best Regards,
Andy Shevchenko