linux-kernel - Re: [PATCH AUTOSEL 6.1 35/35] ext4: deal with legacy signed xattr name hash values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9KKPoEKbp4dwfJg@sashalap>
Date:   Thu, 26 Jan 2023 09:12:14 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Theodore Ts'o <tytso@....edu>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        kernel test robot <oliver.sang@...el.com>,
        Eric Biggers <ebiggers@...nel.org>,
        Andreas Dilger <adilger@...ger.ca>,
        Jason Donenfeld <Jason@...c4.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.1 35/35] ext4: deal with legacy signed xattr
 name hash values

On Wed, Jan 25, 2023 at 11:01:31AM -0500, Theodore Ts'o wrote:
>On Tue, Jan 24, 2023 at 09:23:56AM -0800, Linus Torvalds wrote:
>> On Tue, Jan 24, 2023 at 8:50 AM Linus Torvalds
>> <torvalds@...ux-foundation.org> wrote:
>> >
>> > This patch does not work correctly without '-funsigned-char', and I
>> > don't think that has been back-ported to stable kernels.
>> >
>> > That said, the patch *almost* works.
>>
>> So I'm  not convinced this should be back-ported at all, but it's
>> certainly true that going back and forth between the two cases would
>> be problematic.
>
>Yeah, I wouldn't backport this patch, since it also requires changes
>to e2fsprogs that will take a while to propagate to stable distributions.

Ack, I'll drop it. Thanks!

-- 
Thanks,
Sasha