linux-kernel - Re: [PATCH v3] posix-timers: Prefer delivery of signals to the current thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230126144655.GA4069@redhat.com>
Date:   Thu, 26 Jan 2023 15:46:56 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     Dmitry Vyukov <dvyukov@...gle.com>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        "Eric W . Biederman" <ebiederm@...ssion.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Marco Elver <elver@...gle.com>
Subject: Re: [PATCH v3] posix-timers: Prefer delivery of signals to the
 current thread

On 01/26, Dmitry Vyukov wrote:
>
>  	t = pid_task(pid, type);
> +	if (t && type != PIDTYPE_PID && same_thread_group(t, current))
> +		t = current;
>  	if (!t || !likely(lock_task_sighand(t, &flags)))
>  		goto ret;

Feel free to ignore, this is cosmetic/subjective, but

	t = pid_task(pid, type);
	if (!t)
		goto ret;
	if (type == PIDTYPE_TGID && same_thread_group(t, current))
		t = current;
	if (!likely(lock_task_sighand(t, &flags)))
		goto ret;

looks a bit more readable/clean to me.

LGTM. Lets wait for Thomas verdict.

Reviewed-by: Oleg Nesterov <oleg@...hat.com>