linux-kernel - Re: [PATCH 7/8] gpiolib: split of_mm_gpio_chip out of linux/of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <a181b2dc-5e58-42b2-b689-882f66e6a3b5@app.fastmail.com>
Date:   Thu, 26 Jan 2023 15:54:07 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "Bartosz Golaszewski" <bartosz.golaszewski@...aro.org>,
        "Christophe Leroy" <christophe.leroy@...roup.eu>,
        "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/8] gpiolib: split of_mm_gpio_chip out of linux/of_gpio.h

On Thu, Jan 26, 2023, at 15:08, Andy Shevchenko wrote:
> On Thu, Jan 26, 2023 at 02:28:00PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> This is a rarely used feature that has nothing to do with the
>> client-side of_gpio.h.
>> 
>> Split it out with a separate header file and Kconfig option
>> so it can be removed on its own timeline aside from removing
>> the of_gpio consumer interfaces.
>
> One nit-pick below, otherwise
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>

>>  
>> +config OF_GPIO_MM_GPIOCHIP
>> +	bool
>> +	help
>> +	  This adds support for the legacy 'struct of_mm_gpio_chip' interface
>> +	  from PowerPC. Existing drivers using this interface need to select
>> +	  this symbol, but new drivers should use the generic gpio-mmio
>
> gpio-regmap
>
> I would even not mention gpio-mmio.

Makes sense, thanks!

    Arnd