linux-kernel - Re: [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9KYyPvFsGgZe4Gd@infradead.org>
Date:   Thu, 26 Jan 2023 07:14:16 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     David Howells <dhowells@...hat.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        David Hildenbrand <david@...hat.com>,
        Matthew Wilcox <willy@...radead.org>,
        Jens Axboe <axboe@...nel.dk>, Jan Kara <jack@...e.cz>,
        Jeff Layton <jlayton@...nel.org>,
        Jason Gunthorpe <jgg@...dia.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        linux-fsdevel@...r.kernel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Christoph Hellwig <hch@....de>,
        John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with
 BIO_PAGE_REFFED with inverted logic

On Thu, Jan 26, 2023 at 11:34:10AM +0000, David Howells wrote:
> David Hildenbrand <david@...hat.com> wrote:
> 
> > > Signed-off-by: David Howells <dhowells@...hat.com>
> > > Reviewed-by: Christoph Hellwig <hch@....de>
> > > Reviewed-by: John Hubbard <jhubbard@...dia.com>
> > > cc: Al Viro <viro@...iv.linux.org.uk>
> > > cc: Jens Axboe <axboe@...nel.dk>
> > > cc: Jan Kara <jack@...e.cz>
> > > cc: Matthew Wilcox <willy@...radead.org>
> > > cc: Logan Gunthorpe <logang@...tatee.com>
> > > cc: linux-block@...r.kernel.org
> > > ---
> > 
> > Oh, and I agree with a previous comment that this patch should also hold a
> > Signed-off-by from Christoph above your Signed-off-by, if he is mentioned as
> > the author via "From:".
> 
> I think that was actually in reference to patch 3, but yes - and possibly a
> Co-developed-by tag.  Christoph?

As I said feel free to add a co-developed by if you want.  But more
importantly restore my signoff from here:

http://git.infradead.org/users/hch/misc.git/commitdiff/37ea178d5d95166196112905aa75d85cb0416d49