lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <c851113d-c243-c883-f038-3e61a5b8b066@linaro.org> Date: Thu, 26 Jan 2023 16:41:47 +0100 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Jonathan Cormier <jcormier@...ticallink.com>, Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <robert.foss@...aro.org>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Tomi Valkeinen <tomi.valkeinen@...com>, Jyri Sarha <jsarha@...com> Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Michael Williamson <michael.williamson@...ticallink.com>, Bob Duke <bduke@...ticallink.com> Subject: Re: [PATCH 2/4] DRM: BRIDGE: TFP410: Support basic I2C interface On 25/01/2023 22:09, Jonathan Cormier wrote: > From: Michael Williamson <michael.williamson@...ticallink.com> > > The TFP410 driver does not support I2C. As such, the device remains in > Power Down if the I2C is enabled by the bootstrap pins. > > Add basic support for the I2C interface, and provide support to take > the device out of power down when enabled. Also read the bootstrap mode > pins via the CTL_1_MODE register when using the I2C bus. > > Signed-off-by: Michael Williamson <michael.williamson@...ticallink.com> > Signed-off-by: Jonathan Cormier <jcormier@...ticallink.com> > --- > drivers/gpu/drm/bridge/ti-tfp410.c | 95 +++++++++++++++++++++++++++----------- > 1 file changed, 68 insertions(+), 27 deletions(-) Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). hint: it is entirely different. > > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c > index b9635abbad16..323a6d9ed188 100644 > --- a/drivers/gpu/drm/bridge/ti-tfp410.c > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c > @@ -6,6 +6,7 @@ > > #include <linux/gpio/consumer.h> > #include <linux/i2c.h> > +#include <linux/regmap.h> > #include <linux/media-bus-format.h> > #include <linux/module.h> > #include <linux/of_graph.h> > @@ -21,6 +22,20 @@ (...) > > static void tfp410_i2c_remove(struct i2c_client *client) > @@ -408,7 +449,7 @@ MODULE_DEVICE_TABLE(i2c, tfp410_i2c_ids); > static struct i2c_driver tfp410_i2c_driver = { > .driver = { > .name = "tfp410", > - .of_match_table = of_match_ptr(tfp410_match), > + .of_match_table = tfp410_match, This does not look related to the patch. Best regards, Krzysztof
Powered by blists - more mailing lists