linux-kernel - Re: [PATCH 5/8] gpiolib: remove legacy gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <f7aeabe9-59df-4903-af8e-46766af3f64a@app.fastmail.com>
Date:   Thu, 26 Jan 2023 17:02:13 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "Bartosz Golaszewski" <bartosz.golaszewski@...aro.org>,
        "Christophe Leroy" <christophe.leroy@...roup.eu>,
        "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/8] gpiolib: remove legacy gpio_export

On Thu, Jan 26, 2023, at 15:00, Andy Shevchenko wrote:
> On Thu, Jan 26, 2023 at 02:27:58PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> There are only a handful of users of gpio_export() and
>> related functions.
>> 
>> As these are just wrappers around the modern gpiod_export()
>> helper, remove the wrappers and open-code the gpio_to_desc
>> in all callers to shrink the legacy API.
>
>
> A couple of comments below, after addressing:
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>

Thanks!

>
>> -API参考
>
> Mistakenly removed?

Fixed now.

>>  
>>  	desc = gpio_to_desc(gpio);
>> -	/* reject bogus commands (gpio_unexport ignores them) */
>> +	/* reject bogus commands (gpiod_unexport ignores them) */
>
> While at it,
>
> 	/* reject bogus commands (gpiod_unexport() ignores them) */

Done,

    Arnd