linux-kernel - Re: [PATCH 4/4] arm64: dts: meson: add support for BananaPi M2-Pro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <A5EFDCC3-AB2F-464A-B5B6-1B1482D7D9A4@gmail.com>
Date:   Fri, 27 Jan 2023 18:26:12 +0400
From:   Christian Hewitt <christianshewitt@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic <linux-amlogic@...ts.infradead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: meson: add support for BananaPi M2-Pro


> On 27 Jan 2023, at 5:01 pm, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> 
> On 27/01/2023 11:19, Christian Hewitt wrote:
>>> It's by default. Did any DTSI disable the sound node?
>> 
>> No. I’m simply transcribing from the original M5 dts (with edits to omit
>> the audio jack bits) and the sound nodes of other Amlogic dts which have
>> long included the same. 
>> 
>> Q. Do I need to remove it here? (sounds like a yes)
> 
> Yes

I’ve removed for both dts and sent v2

>> Q. Do we need to exorcise/cleanup the same from all other meson dts?
> 
> Yes, please.

I’ll put on my to-do list :)

Christian